Redefine view #4668
Open
Redefine view #4668
+1,313
−1,481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderZhi
requested review from
dustinxie,
Liuhaai,
envestcc and
a team
as code owners
CoderZhi
commented
Jul 2, 2025
| @@ -130,7 +130,7 @@ func (s *Indexer) StartView(ctx context.Context) (staking.ContractStakeView, err | |||
| } | |||
| return &stakeView{ | |||
| helper: s, | |||
| cache: s.cache.Copy(), | |||
| cache: s.cache.DeepClone(), | |||
envestcc
reviewed
Jul 4, 2025
| cache indexerCache | ||
| bucketsByCandidate map[string]map[uint64]bool // buckets by candidate in current block | ||
| updatedBuckets map[uint64]*Bucket // updated buckets in current block | ||
| deletedBucketIds map[uint64]struct{} // deleted buckets in current block |
There was a problem hiding this comment.
remove field deletedBucketIds, and replacing with updatedBuckets[idx] == nil , may make things simpler
envestcc
reviewed
Jul 4, 2025
| } | ||
|
|
||
| func (w *wrappedCache) IsDirty() bool { | ||
| return w.cache.IsDirty() || w.isDirty() |
There was a problem hiding this comment.
I'm not sure about whether to call cache.IsDirty()
envestcc
reviewed
Jul 4, 2025
| }) | ||
| v.contractsStake = clone |
There was a problem hiding this comment.
the contractStake may have too many wraps, because there is no reset for it after 1 block committed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using "wrappedCache" to wrap a cache and record modifications
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: